Additional refactoring of PacketTunnelActor State; mostly placing clearly subordinate types under appropriate namespaces #6070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:
buggmagnet
force-pushed
the
PacketTunnel-State-refactor-2
branch
from
57ba6e3 to
36a2a27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the refactoring merged to main earlier. In this:
KeyPolicybecomesState.KeyPolicyReconnectReasonbecomesPacketTunnelActor.ReconnectReasonTargetStateForReconnectmoves underStateStatePriorToBlockedStatebecomesState.BlockingData.PriorStateAll these types have been evaluated to be structurally subordinate to the namespaces they have been moved under, meaning that these changes do not introduce any ambiguities, but merely declutter the namespace.
This change is